-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rusk-wallet: Allow withdrawing of partial rewards #3041
Open
Daksh14
wants to merge
4
commits into
master
Choose a base branch
from
withdraw_partial_rewards
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29acc9d
to
407c04e
Compare
moCello
reviewed
Nov 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments, the biggest one being that I would have the stake-reward be an optional value. So that when the user doesn't specify anything, the entire reward is withdrawn.
welf
previously approved these changes
Dec 2, 2024
42b32d6
to
d7770d7
Compare
fe7c1ed
to
a3b0e76
Compare
herr-seppia
requested changes
Jan 22, 2025
754f4f0
to
bc85e70
Compare
Pass reward param to withdraw transaction function Add check for withdraw amount
Rename helper method to be more correct
Signed-off-by: Daksh <[email protected]>
bc85e70
to
c9d8634
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass reward param to withdraw transaction function Add check for withdraw amount
Closes #2538